afpcmd: pagination for long directory listings#286
Merged
Conversation
🤖 Augment PR SummarySummary: Adds interactive pagination to Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
andylemin
approved these changes
Jul 7, 2026
Member
Author
|
example of what the pagination looks like -rw-r--r-- 4096 2025-12-21 17:07 ._.DS_Store
-rw-r--r-- 4096 2025-12-22 12:09 ._Screenshot 2024-02-06 at 9.50.53.png
-rw-r--r-- 8196 2026-04-28 07:46 .DS_Store
-rw-rw-rw- 0 2026-03-09 18:58 AppleShare Server Messages
-rw-r--r-- 3779 2025-10-14 23:13 backup_demo.c
-rw-r--r-- 1101 2025-11-27 23:19 binhex.h
-rw-r--r-- 1974 2025-11-27 23:19 BLURB
-rw-r--r-- 511108 2025-11-01 13:35 bstring-1.0.3.tar.gz
-rw-r--r-- 29985 2025-06-27 21:40 cnid-design-doc.rtf
-rw-rw-r-- 311 2026-01-01 22:42 config
-rw-r--r-- 4173 2025-11-27 23:52 config.h.in
-rw-r--r-- 1172 2025-11-27 23:19 copyin.h
-rw-r--r-- 17976 2025-11-27 23:19 COPYING
-rw-r--r-- 18682 2025-11-27 22:44 debdiff-hfsutils-gcc14
-rw-r--r-- 3575 2023-05-30 03:16 docker-rootful.yaml
-rw-rw-rw- 0 2026-03-22 08:44 Icon
-rw-r--r-- 754 2025-10-17 09:40 Makefile
drwxr-xr-x 0 2024-03-28 14:20 Network Trash Folder
-rw-r--r-- 142570408 2026-03-22 10:24 p.deb
-rw-rw-r-- 142570408 2024-05-19 02:58 pulsar_1.117.2024051704_amd64.deb
-rw-r--r-- 441391 1970-01-01 01:00 Screenshot 2024-02-06 at 9.50.53.png
drwxr-xr-x 0 2024-03-28 14:20 Temporary Items
drwxrwxrwx 0 2025-12-21 18:05 test_recursive_delete_67093
-rw-r--r-- 14 2026-07-07 14:18 testfile_000.txt
-rw-r--r-- 14 2026-07-07 14:18 testfile_001.txt
-rw-r--r-- 14 2026-07-07 14:18 testfile_002.txt
-- 26 entries shown; press any key for next page, or q to quit -- |
0dd4d7f to
e71912e
Compare
we previously had a hard coded limit of 256 entries when listing directories in afpcmd, but now we get a dynamic pagination that is sensitive to the number of rows in the current terminal when the terminal dimensions cannot be determined, we use the 256 entries fallback
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



we previously had a hard coded limit of 256 entries when listing directories in afpcmd, but now we get a dynamic pagination that is sensitive to the number of rows in the current terminal
when the terminal dimensions cannot be determined, we use the 256 entries fallback