Skip to content

fix:[CPCAP-1169] rollback exitcode #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yerkennz wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix:[CPCAP-1169] rollback exitcode #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions services/upgrade/docker/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ function handle_master_upgrade() {

ls -la $MIGRATION_PATH

set +e
Copy link
Copy Markdown
Collaborator

@Tvion Tvion Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we have to use set +e in the end of check_user function to rollback set -e

echo "[$(date +%Y-%m-%dT%H:%M:%S)] Check cluster before upgrade"
/usr/lib/postgresql/"${PG_VERSION_TARGET}"/bin/pg_upgrade \
--old-datadir "/var/lib/pgsql/data/${DATA_DIR}" \
Expand All @@ -110,6 +111,7 @@ function handle_master_upgrade() {
> /var/lib/pgsql/data/check_result

CHECK_CODE=$?
set -e

if [[ "$CHECK_CODE" -ne 0 ]]; then
echo "[$(date +%Y-%m-%dT%H:%M:%S)] Check cluster before upgrade - Failed."
Expand Down Expand Up @@ -244,8 +246,8 @@ check_pgsql_version

if [[ "${TYPE}" == "master" ]]; then
handle_master_upgrade
exit $?
Copy link
Copy Markdown
Collaborator

@Tvion Tvion Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant as we use exit inside

elif [[ "${TYPE}" == "replica" ]]; then
handle_replica_upgrade
exit $?
fi

exit 0
Loading