This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1216 +/- ##
============================================
+ Coverage 63.61% 63.65% +0.03%
- Complexity 2681 2703 +22
============================================
Files 236 236
Lines 13451 13547 +96
Branches 1340 1348 +8
============================================
+ Hits 8557 8623 +66
- Misses 4165 4188 +23
- Partials 729 736 +7 Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 2843
💛 - Coveralls |
| poolConfig.setMinIdle(5); | ||
| poolConfig.setMaxTotal(1000); | ||
| return new JedisCluster(new HostAndPort(host.getHostName(), host.getPort()), poolConfig); | ||
| if (password.length() == 0) { |
Contributor
There was a problem hiding this comment.
Consider using StringUtils.isNotBlank to null check.
Contributor
|
Hey @bharadwajrembar, are you still planning to work on this feature? |
Author
|
@kishorebanala I am held up at the moment. I would not be able to take on this as well as #1209 as of now. If I find bandwidth, I will surely pick it up and inform you of the same. |
Collaborator
|
Closing due to inactivity. Please reopen if you plan to resume working on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #972 , the password is not propagated to the JedisClusterClient and thus, throws an error stating
NOAUTHwhen trying to connect to a Redis instance with Authentication enabled. This PR fixes that. Please review. @kishorebanala @apanicker-nflx , cc: @skyrocknroll