This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Fix: #3876 Update task utils: removeIterationFromTaskRefName#3878
Open
appunni-old wants to merge 5 commits intoNetflix:mainfrom
Open
Fix: #3876 Update task utils: removeIterationFromTaskRefName#3878appunni-old wants to merge 5 commits intoNetflix:mainfrom
appunni-old wants to merge 5 commits intoNetflix:mainfrom
Conversation
Parsing name is not considering task ref name with double underscores - This is not fully fixing the use of this function. There needs to be some kind of validation against the user from setting up the taskRefName with double underscore
Fix: Netflix#3876 Update task utils: removeIterationFromTaskRefName
Contributor
|
Hi @appunni-m can you fix the build? |
Added imports as required
Author
|
@v1r3n hey I have fixed the build. |
Author
Contributor
|
Hi @appunni-m , Is there a particular reason that you are using double underscore in the task reference name? |
Author
|
@manan164 i take it as input from user, thus I don't want to take chances with it. There are no validations against it either. |
Author
|
@manan164 can we merge this ? Any blocker ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing name is not considering task ref name with double underscores
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #3876
If taskRefName with double underscore is not considered, then task creation would go into infinite loop. This can be used also as an attack vector on conductor installation as this causes DDos
Alternatives considered
Add validation in the create start workflow / create workflow definition api
Describe alternative implementation you have considered