Open
Conversation
2) Configure JEDIS client to use REDIS password if available ( i.e. not null)
Contributor
|
That code would probably never be executed because nobody is setting the password. Any thoughts about that? Moreover, it would be nice to include several test cases that showcase the functionality of the added feature and the proper execution. |
Author
|
Plan to use it with netflix conductor. |
Contributor
|
My comment was about the code not being executed, not how you plan to use it. This PR also needs test case coverage. |
Continue if Javadoc build fails
Disable JavaDoc for testing
ipapapa
suggested changes
Feb 9, 2018
Contributor
ipapapa
left a comment
ipapapa
left a comment
There was a problem hiding this comment.
Any plans to move forward? There seem to be a few a things that need to be done.
Contributor
|
This PR can be closed as #244 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow REDIS Auth to be configured as part of host configuration. Configure JEDIS client to set Auth if available in host configuration.