update python deps and fix cloudflare module name (fix #5313)#5314
Open
gijzelaerr wants to merge 5 commits intoNetflix:mainfrom
Open
update python deps and fix cloudflare module name (fix #5313)#5314gijzelaerr wants to merge 5 commits intoNetflix:mainfrom
gijzelaerr wants to merge 5 commits intoNetflix:mainfrom
Conversation
gijzelaerr
requested review from
charhate,
douglasc-nflx,
hosssha,
jmcrawford45 and
jtschladen
as code owners
gijzelaerr
changed the title
Fix RST footnote reference warning in production documentation - Change auto-footnote [*] to numbered footnote [1] in docs/production/index.rst:495 - Resolves Sphinx warning: "Footnote [*] is not referenced" - Maintains same content and functionality with proper reStructuredText syntax
…ableX509 mock - Remove outdated mock for josepy.util.ComparableX509 which no longer exists in current josepy version - Update test to properly mock OpenSSL.crypto functions that are actually used in the implementation - Mock acme_client methods (poll_authorizations, finalize_order) to match real usage - Test now verifies correct return tuple structure instead of unused mocks
Contributor
Author
|
Hi — just checking in on this PR. It's been open for a while and has picked up merge conflicts in the requirements files. I'm happy to rebase it on the latest The core change is small: the Let me know how you'd like to proceed — happy to rework this however works best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the python requirement files and fixes a changes module name for the cloudflare package.