Draft
Conversation
fed1337
requested review from
charhate,
douglasc-nflx,
hosssha,
jmcrawford45 and
jtschladen
as code owners
| data = { | ||
| "parse_mode": "MarkdownV2", | ||
| "chat_id": self.get_option("chat", options), | ||
| "text": "*Lemur {} Notification*\n\n{}".format(notification_type.capitalize(), *attachments), |
Contributor
There was a problem hiding this comment.
Looking at the structure, it should probably be:
For expiration (list of strings)
"text": "Lemur {} Notification\n\n{}".format(
notification_type.capitalize(),
''.join(attachments) # Join the list into one string
)
Or for rotation (single string)
"text": "Lemur {} Notification\n\n{}".format(
notification_type.capitalize(),
attachments # Already a string, no unpacking
)
as currently unpacking will just yield the first element
| @@ -0,0 +1,109 @@ | |||
| """ | |||
Contributor
There was a problem hiding this comment.
Can we add a changelog / amdinistration.rst entry for this as well?
jmcrawford45
approved these changes
Dec 18, 2025
Contributor
jmcrawford45
left a comment
jmcrawford45
left a comment
There was a problem hiding this comment.
Pending open comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very similar to the slack notification plugin. Tests are passed in a slightly different environment with python 3.10