Pass endpoint context to rotation notifications#5398
Merged
jmcrawford45 merged 3 commits intoNetflix:mainfrom Apr 8, 2026
Merged
Pass endpoint context to rotation notifications#5398jmcrawford45 merged 3 commits intoNetflix:mainfrom
jmcrawford45 merged 3 commits intoNetflix:mainfrom
Conversation
Thread the endpoint parameter through send_rotation_notification() and into send_default_notification() via **kwargs, so notification plugins can include operational context (e.g. which load balancer is being rotated) in their messages. This is backwards compatible — the endpoint parameter is optional and existing plugins that don't use it will simply ignore it via their **kwargs signature. Closes Netflix#5346 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
0xb8000
requested review from
charhate,
douglasc-nflx,
hosssha,
jmcrawford45 and
jtschladen
as code owners
Verifies that send_rotation_notification passes the endpoint kwarg through to send_default_notification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmcrawford45
approved these changes
Apr 7, 2026
|
Coverage is 60.861% — 0xb8000:fix/5346-rotation-notification-endpoint-context into Netflix:main. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endpointparameter tosend_rotation_notification()inmessaging.pysend_default_notification()via**kwargs, making it available to notification pluginscli.pyto pass the endpoint being rotatedThis is fully backwards compatible — the
endpointparameter defaults toNone, and existing notification plugins already accept**kwargsin theirsend()signature.Closes #5346
Test plan
send_rotation_notification(cert)without endpoint)**kwargscan now accessendpointfrom kwargs when handling rotation events🤖 Generated with Claude Code