Skip to content

ConstIntSemiring now requires Ord #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frozenspider merged 1 commit into from
Jun 11, 2026
Merged

ConstIntSemiring now requires Ord #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/field/ark_ff_field.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ use ark_serialize::{
CanonicalSerializeWithFlags, Compress, Flags, Read, SerializationError, Valid, Validate, Write,
};
use core::{
cmp::Ordering,
fmt::{Display, Formatter, Result as FmtResult},
hash::{Hash, Hasher},
iter::{Product, Sum},
Expand All @@ -26,7 +25,7 @@ use ark_std::{UniformRand, rand::prelude::*};
#[cfg(feature = "rand")]
use rand::distr::StandardUniform;

#[derive(Clone, Copy, PartialEq, Eq, InfallibleCheckedOp)]
#[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord, InfallibleCheckedOp)]
#[infallible_checked_unary_op((CheckedNeg, neg))]
#[infallible_checked_binary_op((CheckedAdd, add), (CheckedSub, sub), (CheckedMul, mul))]
#[repr(transparent)]
Expand Down Expand Up @@ -76,20 +75,6 @@ impl<F: ArkWrappedPrimeField> Default for ArkField<F> {
}
}

impl<F: ArkWrappedPrimeField> PartialOrd for ArkField<F> {
#[inline(always)]
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
Some(self.cmp(other))
}
}

impl<F: ArkWrappedPrimeField> Ord for ArkField<F> {
#[inline(always)]
fn cmp(&self, other: &Self) -> Ordering {
Ord::cmp(&self.0, &other.0)
}
}

impl<F: ArkWrappedPrimeField> Hash for ArkField<F> {
fn hash<H: Hasher>(&self, state: &mut H) {
self.0.hash(state)
Expand Down
4 changes: 2 additions & 2 deletions src/semiring.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ impl<T> IntSemiringWithShifts for T where
{
}

pub trait ConstIntSemiring: IntSemiring + ConstSemiring + FromStr {}
impl<T> ConstIntSemiring for T where T: IntSemiring + ConstSemiring + FromStr {}
pub trait ConstIntSemiring: IntSemiring + ConstSemiring + Ord + FromStr {}
impl<T> ConstIntSemiring for T where T: IntSemiring + ConstSemiring + Ord + FromStr {}

macro_rules! primitive_int_semiring {
($t:ident) => {
Expand Down
Loading