Issue when running Sedge with a non root user#303
Issue when running Sedge with a non root user#303cbermudez97 wants to merge 7 commits intodevelopfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #303 +/- ##
===========================================
+ Coverage 86.69% 86.80% +0.10%
===========================================
Files 78 78
Lines 4578 4614 +36
===========================================
+ Hits 3969 4005 +36
Misses 523 523
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
AntiD2ta
left a comment
AntiD2ta
left a comment
There was a problem hiding this comment.
Thank you for opening such a nicely done PR very quickly! It seemed you had some fun doing this.
I wonder if these changes affect somehow clients other than Teku. Did you try several combinations?
I made some comments to be solved
| } | ||
| for _, datadir := range datadirs { | ||
| if datadir.createIf { | ||
| if _, err := os.Stat(datadir.path); os.IsNotExist(err) { |
There was a problem hiding this comment.
You are ignoring err here except when it is an os.IsNotExist. Is this intentional? There could be another type of error related to something else.
Co-authored-by: Miguel Tenorio <46824157+AntiD2ta@users.noreply.github.com>
3 participants
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?