Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| className, | ||
| ...props | ||
| }) => ( | ||
| <SelectPrimitive.Trigger asChild {...props}> |
There was a problem hiding this comment.
Why do we want removing this (asChild)?
There was a problem hiding this comment.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- plugin/src/components/ui_components/Select/styles.css: Language not supported
- plugin/src/features/Environment/styles.css: Language not supported
Comments suppressed due to low confidence (2)
plugin/src/components/ui_components/Select/index.tsx:17
- Removing the wrapper and the 'asChild' prop in the Trigger component changes the default clickable behavior; please verify that this alteration is intentional and update usage documentation as needed.
<SelectPrimitive.Trigger className={`SelectTrigger ${className ?? ""}`} {...props}>
plugin/src/components/ui_components/Select/index.tsx:27
- Switching from 'asChild' to directly rendering the Content with additional popper properties may modify the DOM structure and behavior; please confirm that dependent components are updated to align with this change.
<SelectPrimitive.Content
|
the dropdown was not getting the animations i wanted to added, that was not intentional, i'll fix it |
varex83
left a comment
varex83
left a comment
There was a problem hiding this comment.
Can you also add cursor style change while the select is opened. Now it set to default one (arrow), but we want to show hand cursor
sure |
enhanced dropdowns in the settings section with more dynamic ui
closes #319