Conversation
…lly (wormhole-foundation#4497) * ci(gocritic): use deny-list for disabled rules so that newly added rules will get run - Ensures that all rules are enabled by default with a deny-list, instead of disabling all rules and using an allow-list. This change allows us to benefit from new rules that could be added to gocritic in the future. Our current policy in CI is to fail on new rules and this is already in place for e.g. clippy lints for new Rust releases. * fix singleCaseSwitch lint violation * formatting
* Log version of EVM node * Log version of Solana node * Log version of Algorand node * Log version of Aptos node * Log version of Sui node * Log version of NEAR node * Log version of Cosmwasm node * Mock the version response for NEAR tests
* node: Add Transfer Verifier whitepaper
…on#4429) - Change the function visibility for Governor methods that are currently only used internally by the package. This helps to minimize the API for the Governor package.
…dation#4430) - Pass a testing instance to the set-up function and exit early on nil/err conditions rather than making each individual test perform this action
ci: Add `nilnil` and `nilnesserr` lints (wormhole-foundation#4516) Find the code that returns nil even if it checks that the error is not nil. https://golangci-lint.run/docs/linters/configuration/#nilerr Checks that there is no simultaneous return of nil error and an invalid value. https://golangci-lint.run/docs/linters/configuration/#nilnil
Co-authored-by: djb15 <djb15@users.noreply.github.com>
…or token2022 tokens (including metadata pointers)
scripts: add fogo to contract-upgrade-governance.sh
this brave new multi-SVM world solana: fix typo in constant name
Previously, OUR_CHAIN_ID (1 in the case of solana), CHAIN_ID_GOVERNANCE (1), and the constant '1' were used interchangeably. We fix that now by using the appropriate constant everywhere
Tiltfile: set CHAIN_ID in solana build config solana: add CHAIN_ID to Dockerfile.client and Dockerfile.wasm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.