Conversation
Oghma
requested changes
Apr 3, 2026
…age, and MINIMUM_CONTRACT_BALANCE
Oghma
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements all 11 fixes from Wormhole team review feedback on the Stellar core contract.
set_current_indexnow extends TTL on write, preventing the contract from becoming non-functional if the entry gets archived.update_current_contract_wasmdoesn't use it.GOVERNANCE_EMITTERconst directly; constructor validates the param matches the const instead of persisting it.post_message_with_feenow extends the MessageFee TTL when fee is non-zero, preventing silent fallback to free messaging.verify_and_hash_governance_vaanow callsverify_vaa_signaturesdirectly instead ofverify_vaa, which was internally re-parsing the VAA.Result<(), WormholeError>toResult<bool, WormholeError>; errors are now reserved for parse failures only.parseAndVerifyVM;verify_vaanow delegates to it internally.VAA::try_fromnow rejects VAAs with version != 1, matching EVM.transfer_fees; Soroban contracts cannot be deallocated for having zero XLM.extend_ttlwas unnecessary cost.