Add affine virtual booleanity MLEs#222
Open
latifkasuli wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next atomic follow-up after #221 for #185, which blocks #91.
What changed
UairSignature::num_booleanity_bin_cols()as the signature-derived count for committed witness binary columns plus affine virtual booleanity targets, without changing committed/PCS column counts.build_affine_virtual_bit_slice_mlesfor materializing affine virtual residual bit-slice MLEs from binary source columns, including shifted terms and1_Doffsets.prepare_affine_virtual_sumcheck_group, which routes affine virtual targets through a separate generic degree-3 booleanity group instead of theBinaryPolyround-1 fast path.Intentionally deferred
num_booleanity_bin_cols()is deferred to the next atomic PR.Validation
./.githooks/pre-push