Open
Conversation
Changed line 101 to be READONLY values rather than DISABLED. DISABLED form values do not submit; therefore if these trigger they are never submitted to checkout.
tasmaniaman
suggested changes
Sep 11, 2019
tasmaniaman
left a comment
tasmaniaman
left a comment
There was a problem hiding this comment.
Do you need the extra IF in the class section?
E.g. class="form-control cart-qty [%if [@aff_id@] eq 'free'%] readonly [%/if%]"
|
@GerryFort @tasmaniaman it only requires to be an attribute for Bootstrap 4, it uses that for the styles: |
Contributor
Author
|
@philcon93 understand. Seeing line 67 had it; I thought I'd put it in my edit to comply with existing code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed line 101 to be READONLY values rather than DISABLED. DISABLED form values do not submit; therefore if these trigger and changes are made to the cart, these items get removed. Changed to READONLY to address this.