-
Notifications
You must be signed in to change notification settings - Fork 225
Improve dataset compatibility error messages for evaluations #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
|
Please fix the pre-commit @copilot |
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
|
Can you please fill the whats new file? you can put my name Bruno Aristimunha @copilot |
|
fix the test please @copilot: FAILED moabb/tests/test_verbose.py::test_verbose_warning - AssertionError: assert 'not compatible with evaluation' in 'WARNING moabb.paradigms.motor_imagery:motor_imagery.py:345 Choosing from all possible events\nWARNING moabb.evaluations.base:base.py:174 <moabb.datasets.fake.FakeDataset object at 0x143df9d00> not compatible with CrossSessionEvaluation: dataset has only 1 session(s), but CrossSessionEvaluation requires at least 2 sessions. Removing this dataset from the list.\n'
|
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Fixed in commit 21ebf33. Updated all three tests in |
|
@copilot empty trigger please |
Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Plan: Improve Cross-Session Evaluation Error Messages ✅
Summary
This PR successfully improves error messages for dataset compatibility checks in MOABB evaluations, making them more informative and helpful for users.
Changes Made (5 files, +69/-9 lines):
moabb/evaluations/base.py (+24/-1):
_get_incompatibility_reason()method to provide specific reasonsmoabb/evaluations/evaluations.py (+31/-2):
_get_incompatibility_reason()for CrossSessionEvaluation and CrossSubjectEvaluationself.__class__.__name__moabb/evaluations/splitters.py (+1/-1):
moabb/tests/test_evaluations.py (+11):
test_incompatibility_error_message()to verify improved messagesdocs/source/whats_new.rst (+1):
moabb/tests/test_verbose.py (+4/-5):
Quality Checks:
✅ All 31 tests passed (5 skipped) including test_verbose.py
✅ Code review completed and feedback addressed
✅ Security scan: 0 alerts
✅ All pre-commit checks passing
✅ What's new file updated
✅ Demonstration script validates clear error messages
Security Summary:
No security vulnerabilities were introduced or discovered during the implementation.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.