Skip to content

Restrict Plexon2RecordingInterface to Windows#1001

Merged
rly merged 10 commits intomainfrom
add_pl2_interface
Mar 5, 2026
Merged

Restrict Plexon2RecordingInterface to Windows#1001
rly merged 10 commits intomainfrom
add_pl2_interface

Conversation

@rly
Copy link
Collaborator

@rly rly commented Jul 2, 2025

Fix #915

TODO:

  • Restrict usage to Windows distributions

@rly
Copy link
Collaborator Author

rly commented Jul 2, 2025

I'm getting an error from neuroconv when getting the extractor -> spikeinterface/extractors/neoextractors/plexon2.py -> spikeinterface/extractors/neoextractors/neobaseextractor.py line 218 that "stream_id 3 is not in []". Investigating.

@rly
Copy link
Collaborator Author

rly commented Jul 2, 2025

This seems to have been resolved in neuroconv 0.6.2 catalystneuro/neuroconv#1058.

This could also be resolved by limiting neo version to <=0.13.3 but then spikeinterface needs to be downgraded which lowers the zarr version, which lowers the hdmf-zarr version, and so on. Might be better to bump to just support neuroconv 0.6.2 with the fix.

@rly
Copy link
Collaborator Author

rly commented Jul 3, 2025

Installing neuroconv 0.6.2 from pypi does not install its extras (see catalystneuro/neuroconv#1116). This is fixed in neuroconv 0.6.5. So I think it would be best to punt PL2 support to when neuroconv 0.6.5 support is added.

bendichter and others added 5 commits July 17, 2025 09:59
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Plexon2 SDK only supports Windows, so exclude the interface
on other platforms in both the backend API and frontend UI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rly rly changed the title Add first try at Plexon2RecordingInterface Restrict Plexon2RecordingInterface to Windows Mar 5, 2026
rly and others added 4 commits March 5, 2026 11:16
Resolve conflict: remove autogenerated SourceData.stories.js
(no longer stored in repo)
This directory is already in .gitignore — autogenerated schemas
should not be stored in the repo.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of excluding Plexon2RecordingInterface from the backend on
non-Windows, let it appear in the search list as disabled with a
"Windows only" label. This informs users about the platform requirement
rather than silently hiding the option.

- Remove backend sys.platform check in get_all_interface_info()
- Export windowsOnlyInterfaces from globals
- Pass disabledReason to Search options for per-item disabled labels
- Support per-item --disabled-label override in Search component

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rly rly marked this pull request as ready for review March 5, 2026 19:39
@rly rly requested a review from bendichter March 5, 2026 20:40
@bendichter
Copy link
Collaborator

image

Working for me

@rly rly merged commit 19b19ba into main Mar 5, 2026
27 checks passed
@rly rly deleted the add_pl2_interface branch March 5, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support reading pl2

2 participants