Skip to content

Fix deprecated set-output and behavior cache key typo#1067

Merged
bendichter merged 4 commits intomainfrom
fix-set-output-deprecation
Mar 4, 2026
Merged

Fix deprecated set-output and behavior cache key typo#1067
bendichter merged 4 commits intomainfrom
fix-set-output-deprecation

Conversation

@bendichter
Copy link
Collaborator

@bendichter bendichter commented Mar 4, 2026

Summary

  • Migrate from deprecated ::set-output to $GITHUB_OUTPUT in example_data_cache.yml and testing_pipelines.yml (deprecated Oct 2022, disabled June 2023)
  • Add error handling so a failed GIN fetch fails the step instead of silently producing an empty cache key (which caused cache misses like we saw in PR Speed up tutorial data generation #1064)
  • Fix case typo in behavior dataset cache key: HASH_behavior_DATASETHASH_BEHAVIOR_DATASET (this caused behavior cache lookups to always miss)

Test plan

  • Verify ExampleDataCache jobs pass on all 4 OS runners
  • Verify ExampleDataTests pipeline tests can find cached data
  • Verify behavior dataset cache is now hit correctly (new cache key format)

🤖 Generated with Claude Code

bendichter and others added 4 commits March 4, 2026 14:00
Migrate from deprecated `::set-output` to `$GITHUB_OUTPUT` in both
workflow files, and add error handling so a failed GIN fetch fails the
step instead of silently producing an empty cache key. Also fix the
case typo in behavior dataset cache key (`HASH_behavior_DATASET` →
`HASH_BEHAVIOR_DATASET`) which caused cache lookups to always miss.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The multi-line bash syntax (if/then, >> $GITHUB_OUTPUT) doesn't work
in PowerShell, which is the default shell on Windows runners. Adding
a default bash shell matches the testing_pipelines.yml convention.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@bendichter bendichter merged commit dc9f6bb into main Mar 4, 2026
25 checks passed
@bendichter bendichter deleted the fix-set-output-deprecation branch March 4, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants