Update CI workflows: bump actions, fix inconsistencies, remove dead code#1068
Merged
Update CI workflows: bump actions, fix inconsistencies, remove dead code#1068
Conversation
…onda-remove-defaults - Bump all GitHub Actions to latest major versions: actions/checkout v1/v3/v4 → v6, actions/setup-python v4 → v6, actions/setup-node v3/v4 → v6, actions/cache v4 → v5, actions/upload-artifact v4 → v7, codecov/codecov-action v4 → v5, dawidd6/action-send-mail v3 → v11, tibdex/github-app-token v1.7.0 → v2, actions/add-to-project v0.4.0 → v1, conda-incubator/setup-miniconda v2 → v3, apple-actions/import-codesign-certs v2 → v6 - Add conda-remove-defaults: true to all setup-miniconda steps - Fix Node.js 18 → 20 in Windows deploy workflow - Fix stale comment referencing macos-13 instead of macos-15-intel - Remove unnecessary setup-python steps from deploy workflows (conda handles Python) - Align Windows deploy to use miniforge like all other workflows - Fix sonpy cleanup to run on all macOS runners using find instead of hardcoded path - Remove unused python-version matrix variable from example_data_cache - Standardize conda env update flags to --name/--file across all workflows - Replace git fetch --prune --unshallow --tags with checkout fetch-depth: 0 - Add explanatory comment to Chromatic workflow about snapshot quota Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sonpy is not compatible with Python 3.10+, and the project now uses Python 3.12. Remove Spike2RecordingInterface from supported interfaces, remove all sonpy cleanup steps from workflows, and remove the related comment from the Mac arm64 environment file. Also add fetch-depth: 0 and fetch-tags: true to both deploy workflows so electron-builder can resolve versions from git tags. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The GPU process on macOS Intel CI runners can fail to initialize, crashing the network service and causing E2E tests to time out. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
electron-builder reads the version from package.json, not git tags, so a full clone is unnecessary for deploy workflows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…depth and redundant env - Replace tibdex/github-app-token@v2 (deprecated) with the official actions/create-github-app-token@v2 - Remove fetch-depth: 0 and fetch-tags: true from all test workflows; nothing in the codebase uses git history or tags at test time - Remove redundant CACHE_NUMBER env pass-through in testing_flask_build_and_dist Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bendichter
approved these changes
Mar 5, 2026
Collaborator
bendichter
left a comment
bendichter
left a comment
There was a problem hiding this comment.
lgtm. The CI is passing so let's merge!
Collaborator
Author
|
Let me investigate the chromatic failure (chromatic runs only on PR approval) |
The v1 → v6 checkout upgrade changed the default fetch depth from full to shallow, causing Chromatic to fail with "Found only one commit". Also bump chromaui/action from v1 (CLI v11) to v15 (CLI v15). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Chromatic run passes: https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/22731869191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernize and clean up all GitHub Actions workflows.
Action version bumps
actions/checkoutv1/v3/v4 → v6actions/setup-pythonv4 → v6 (then removed — see below)actions/setup-nodev3/v4 → v6actions/cachev4 → v5actions/upload-artifactv4 → v7actions/add-to-projectv0.4.0 → v1codecov/codecov-actionv4 → v5conda-incubator/setup-minicondav2 → v3apple-actions/import-codesign-certsv2 → v6dawidd6/action-send-mailv3 → v11tibdex/github-app-tokenv1.7.0 → replaced withactions/create-github-app-token@v2(tibdex action is deprecated)chromaui/actionv1 → v15Fixes and cleanup
Spike2RecordingInterfacefrom supported interfaces, all sonpy cleanup steps from workflows, and stale comments from environment filesconda-remove-defaults: trueto allsetup-minicondasteps to fix the "defaults channel might have been added implicitly" warningminiforge-version: latest+ separateconda env updatelike all other workflowssetup-pythonfrom deploy workflows (conda handles Python)fetch-depth: 0from deploy workflows — they don't use git history or tags. Keptfetch-depth: 0for Chromatic, which needs full history to determine baseline commits.conda env updateflags to--name nwb-guide --fileacross all workflowsCACHE_NUMBERenv pass-through in testing_flask_build_and_distTest plan
add_to_nwb_dashboardworkflow fires on next new issue (testsactions/create-github-app-tokenmigration)🤖 Generated with Claude Code