Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1836 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 27 27
Lines 2623 2623
Branches 685 685
=======================================
Hits 2413 2413
Misses 138 138
Partials 72 72
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mavaylon1 is also working on a tutorial for this |
|
Where is it? |
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
|
Thanks for the review, @oruebel. I've made a bunch of these changes. I haven't yet included |
…_remove_containers tutorial
|
@oruebel ok, this is ready for another round of review |
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
Overall this looks good to me. I added a few suggestions for minor edits on text, but nothing critical. Feel free to accept/reject the suggestions as necessary. @rly do you know whether it is possible to change the values of attributes directly in PyNWB. I vaguely remember that PyNWB/HDMF was tracking changes to attribute values so that one can set the values and then call |
This is not allowed because |
Thanks for the clarification. In that case, I think this is good to go. |
|
Thanks @bendichter ! One thing I missed, we should also make a thumbnail for this tutorial. The PowerPoint file with all the Thumbnail sources is in the repo here https://github.com/NeurodataWithoutBorders/pynwb/blob/dev/docs/source/figures/gallery_thumbnails.pptx |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
How to test the behavior?
Checklist
flake8from the source directory.