Conversation
EOL was Oct 31 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2141 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 29 29
Lines 2945 2945
Branches 757 757
=======================================
Hits 2804 2804
Misses 84 84
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com>
There was a problem hiding this comment.
One other suggestion otherwise looks good to me! I will let @rly add any comments and can then update the PR required checks to use the new minimum test workflow versions before merging.
Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com>
|
Thanks for this PR @bendichter ! It looks all good to me. This should be in a minor release. We should also explore adding Python 3.14 support in a separate PR. |
|
We'll make a bugfix release imminently and then do a minor release with this PR deprecating python 3.9 shortly after |
Resolve merge conflicts in CI workflow files by keeping Python 3.10 minimum entries (dropping Python 3.9). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@rly this is ready to go |
Python 3.10 supports ARM, so no need for an Intel-specific runner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
h5py 3.7.0 is the first version with macosx_arm64 wheels, allowing minimum tests to run on macos-latest instead of Intel runners. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Can you update the workflows so that all minimum tests on macos use macos-15-intel, and set the minimum h5py version to 3.6.0 (same as hdmf)? |
Per review: keep h5py minimum at 3.6.0 (matching hdmf) and use macos-15-intel for all macOS minimum tests since h5py 3.6.0 lacks ARM wheels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
EOL was Oct 31 2025
Checklist
ruff check . && codespellfrom the source directory.