Update ecephys electrodes diagram to reflect DeviceModel usage#2158
Open
subh123321 wants to merge 3 commits intoNeurodataWithoutBorders:devfrom
Open
Update ecephys electrodes diagram to reflect DeviceModel usage#2158subh123321 wants to merge 3 commits intoNeurodataWithoutBorders:devfrom
subh123321 wants to merge 3 commits intoNeurodataWithoutBorders:devfrom
Conversation
Contributor
|
This looks good, but the background should be transparent instead of dark gray. Could you please upgrade the background? The new text should also not have a drop-shadow. Could you please remove that? Thank you, and sorry for the delay in response. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2158 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 29 29
Lines 2945 2945
Branches 757 757
=======================================
Hits 2804 2804
Misses 84 84
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the UML-like electrodes diagram in the ecephys tutorial to reflect
current DeviceModel usage. Shared device metadata (e.g., manufacturer) is shown on
DeviceModel, with Device referencing the model.
This follows reviewer guidance related to #2094.