Clean up .h5 test artifact from test_warn_for_nwb_extension#2169
Merged
Conversation
test_warn_for_nwb_extension creates a .h5 file but tearDown only cleaned up the .nwb file. Add cleanup for the .h5 file, remove the accidentally committed file, and add *.h5 to .gitignore. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2169 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 29 29
Lines 2945 2945
Branches 757 757
=======================================
Hits 2804 2804
Misses 84 84
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@rly how big was the file? Big enough that we should consider a rebase? |
Collaborator
|
Oh, I see, 184KB. OK, not worth it. |
bendichter
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_warn_for_nwb_extensioninTestNWBHDF5IOcreates a.h5file buttearDownonly cleaned up the.nwbfile, leavingtest_pynwb_io_nwbhdf5.h5behind.h5cleanup totearDown, remove the accidentally committed file, and add*.h5to.gitignoreTest plan
test_warn_for_nwb_extensionstill passes.h5file is left behind after test run🤖 Generated with Claude Code