Skip to content

Clean up .h5 test artifact from test_warn_for_nwb_extension#2169

Merged
rly merged 2 commits intodevfrom
fix/cleanup-test-h5-file
Mar 5, 2026
Merged

Clean up .h5 test artifact from test_warn_for_nwb_extension#2169
rly merged 2 commits intodevfrom
fix/cleanup-test-h5-file

Conversation

@rly
Copy link
Contributor

@rly rly commented Mar 5, 2026

Summary

  • An earlier commit accidentally included a test file artifact that was not properly cleaned up.
  • test_warn_for_nwb_extension in TestNWBHDF5IO creates a .h5 file but tearDown only cleaned up the .nwb file, leaving test_pynwb_io_nwbhdf5.h5 behind
  • Add .h5 cleanup to tearDown, remove the accidentally committed file, and add *.h5 to .gitignore

Test plan

  • Verify test_warn_for_nwb_extension still passes
  • Verify no .h5 file is left behind after test run

🤖 Generated with Claude Code

test_warn_for_nwb_extension creates a .h5 file but tearDown only
cleaned up the .nwb file. Add cleanup for the .h5 file, remove
the accidentally committed file, and add *.h5 to .gitignore.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rly rly requested a review from bendichter March 5, 2026 20:48
@rly rly enabled auto-merge (squash) March 5, 2026 20:48
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (d0393e9) to head (4726254).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2169   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          29       29           
  Lines        2945     2945           
  Branches      757      757           
=======================================
  Hits         2804     2804           
  Misses         84       84           
  Partials       57       57           
Flag Coverage Δ
integration 72.93% <ø> (ø)
unit 85.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bendichter
Copy link
Collaborator

@rly how big was the file? Big enough that we should consider a rebase?

@bendichter
Copy link
Collaborator

Oh, I see, 184KB. OK, not worth it.

@rly rly merged commit 5980e7a into dev Mar 5, 2026
26 checks passed
@rly rly deleted the fix/cleanup-test-h5-file branch March 5, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants