Apply formatting and remove more trace statements#209
Open
MrDOS wants to merge 2 commits intoNeuronRobotics:devfrom
Open
Apply formatting and remove more trace statements#209MrDOS wants to merge 2 commits intoNeuronRobotics:devfrom
MrDOS wants to merge 2 commits intoNeuronRobotics:devfrom
Conversation
fwolter
approved these changes
Feb 1, 2021
Collaborator
fwolter
left a comment
fwolter
left a comment
There was a problem hiding this comment.
LGTM, checked the removal of the trace logging. That's a real bunch...
I'm fine with your formatting proposals.
Comment on lines
3463
to
3464
| sprintf( msg, "readByte return(%i)\n", bytes ? buffer[ 0 ] : -1 ); | ||
| report( msg ); |
Collaborator
There was a problem hiding this comment.
I think these sprintf loggings could be removed, too. But one step after another.
| (*eis->env)->ExceptionDescribe(eis->env); | ||
| (*eis->env)->ExceptionClear(eis->env); | ||
| } | ||
| #endif /* asdf */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies formatting (via Spotless) to the Java source code using the Eclipse JDT default formatting. Now that I see the magnitude of the changeset, I think I'm going to make some tweaks to the formatting rules to try to minimize the changes. Placing opening braces on a new line and not rewrapping lines which are already shorter than the line length limit would drastically cut down on the number of changes, I think, and it turns out I do care more than I thought I did about the wrapping of multiple arguments. I don't like the way it wraps only some of the arguments:
or worse, rewraps only a few of the arguments onto the first line, and leaves the rest hanging:
I did also try applying the Eclipse CDT formatter to the C source, and was pretty disappointed with the results. Again, mostly over unnecessary re-wrapping of lines.