Open
Conversation
- http://localhost:8080/index.html 요청의 header 값을 읽는다. - /webapp/index.html 파일을 읽어 response body를 만든다. - 응답 헤더와 바디를 OutputStream을 통해 클라이언트에 전송한다.
- Path객체 생성하는 방법 변경 - File.toPath()로 변경 : header에 추출한 url을 그대로 사용가능하여 변경. - Path.of()는 /없도록 파싱하는 로직이 필요하여 변경.
- RequestHeader 가 아래 3개의 속성 가지고 있다. RequestLine requestLine; List<String> requestHeaders; List<String> body; - RequestLine은 httpMethod, url, httpVersion로 구성
- request.handleUserRequest(in)에서 요청을 읽어 파싱하고 - response.makeResponse(requestLine.getUrl(), out)에서 응답 생성
- 요구사항에는 없었지만 확인차
nathan29849
added a commit
that referenced
this pull request
Jul 27, 2022
nathan29849
added a commit
that referenced
this pull request
Jul 27, 2022
feat: [#7] css, js, ico 등 html이 아닌 파일에 대해 GET 요청 처리
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Todo