Skip to content

3月のパッケージアップデート #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ienaga merged 3 commits into from
Mar 1, 2026
Merged

3月のパッケージアップデート #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12b91e5
Bump minimatch
dependabot[bot] Feb 28, 2026
8c8ca0b
Merge pull request #60 from Next2D/dependabot/npm_and_yarn/multi-770c…
ienaga Mar 1, 2026
fcdae28
#61 3月のパッケージアップデート
ienaga Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,40 +3,38 @@ name: Lint
on:
push:
branches:
- main
- develop
pull_request:
branches:
- main
- develop
workflow_call:

jobs:
macos-browser-test:
runs-on: macos-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 24
registry-url: "https://registry.npmjs.org"
- run: npm install -g npm@latest
- run: npm install
- run: npm ci
- run: npm run lint

windows-browser-test:
runs-on: windows-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 24
registry-url: "https://registry.npmjs.org"
- run: npm install -g npm@latest
- run: npm install
- run: npm ci
- run: npm run lint
10 changes: 9 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,23 @@ permissions:
contents: read

jobs:
lint:
uses: ./.github/workflows/lint.yml

Copilot AI Mar 1, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publish now waits on the reusable lint workflow, which runs on macOS and Windows. This will significantly increase release latency and runner cost for every push to main; if the goal is only a pre-publish sanity check, consider calling a lighter-weight lint job (e.g., Ubuntu-only) or splitting the workflow so cross-OS lint remains on PRs while publish gates on a faster check.

Suggested change
uses: ./.github/workflows/lint.yml
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 24
- run: npm ci
- run: npm run lint

Copilot uses AI. Check for mistakes.

publish:
needs: [lint]
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
id-token: write
Comment on lines +19 to +22

Copilot AI Mar 1, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish job now requests pull-requests: write, but this workflow only runs on push to main and the steps shown don’t interact with PRs. This is broader than necessary and increases the blast radius if a dependency/script is compromised; consider removing pull-requests: write (and keep only the minimum permissions required for publishing, e.g. contents: read plus id-token: write only if you’re using OIDC/provenance).

Suggested change
permissions:
contents: read
pull-requests: write
id-token: write

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 24
registry-url: "https://registry.npmjs.org"
- run: npm install -g npm@latest
- run: npm install
- run: npm ci
- run: npm run release
- run: npm publish
Loading
Loading