Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
依存パッケージ群のバージョン更新を行い、開発・ビルド環境（VS Code/TypeScript/vsce など）を最新化するPRです。
Changes:
@types/vscode/@vscode/vsce/typescriptのバージョン更新- VS Code の対応バージョン（
engines.vscode）を^1.115.0に更新 package-lock.jsonの追従更新（関連する依存関係の解決結果更新）
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | 開発依存と engines.vscode のバージョン更新 |
| package-lock.json | 依存解決結果（ロックファイル）の更新 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+68
| "@types/vscode": "^1.116.0", | ||
| "@typescript-eslint/eslint-plugin": "^8.58.2", | ||
| "@typescript-eslint/parser": "^8.58.2", | ||
| "@vscode/vsce": "^3.8.0", | ||
| "@vscode/vsce": "^3.9.0", | ||
| "eslint": "^10.2.0", | ||
| "eslint-plugin-unused-imports": "^4.4.1", | ||
| "globals": "^17.5.0", | ||
| "typescript": "^6.0.2", | ||
| "typescript": "^6.0.3", | ||
| "vitest": "^4.1.4" | ||
| }, | ||
| "engines": { | ||
| "node": ">=22.0.0", | ||
| "vscode": "^1.110.0" | ||
| "vscode": "^1.115.0" |
There was a problem hiding this comment.
engines.vscode is set to ^1.115.0 while @types/vscode is ^1.116.0. This can let the code compile against newer VS Code APIs than the extension claims to support, causing runtime failures on older versions. Consider pinning @types/vscode to match the minimum supported VS Code version (or raising engines.vscode to the same level).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.