Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the VS Code type dependency version to better align with the extension’s declared VS Code engine compatibility.
Changes:
- Updates
@types/vscodeversion range inpackage.jsonfrom^1.116.0to^1.115.0. - Updates the corresponding
@types/vscodeentry inpackage-lock.json.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Lowers the declared @types/vscode devDependency range to ^1.115.0. |
| package-lock.json | Mirrors the dependency range change for @types/vscode in the lockfile metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@eslint/js": "^10.0.1", | ||
| "@types/node": "^25.6.0", | ||
| "@types/vscode": "^1.116.0", | ||
| "@types/vscode": "^1.115.0", |
There was a problem hiding this comment.
The PR title suggests a package update, but this change is a downgrade (1.116 -> 1.115). Please clarify the intent in the PR description/commit message (e.g., aligning with engines.vscode) so reviewers understand why we're moving to an older version.
| "@eslint/js": "^10.0.1", | ||
| "@types/node": "^25.6.0", | ||
| "@types/vscode": "^1.116.0", | ||
| "@types/vscode": "^1.115.0", |
There was a problem hiding this comment.
Changing @types/vscode from ^1.116.0 to ^1.115.0 still permits installing 1.116.x (caret range). If the goal is to keep typings aligned with engines.vscode (^1.115.0) and avoid newer API types, pin to 1.115.0 (or use ~1.115.0) and regenerate the lockfile so the installed version matches.
| "@types/vscode": "^1.115.0", | |
| "@types/vscode": "1.115.0", |
No description provided.