upgraded to elkjs 0.11.1#32
Open
el3ctrician wants to merge 2 commits into
Open
Conversation
Nic30
reviewed
May 14, 2026
| if (this.layouter) { | ||
| try { | ||
| this.layouter.terminateWorker(); | ||
| } catch(e) {} |
Owner
There was a problem hiding this comment.
Can you set your IDE/autoformat/editor to same style so the whitespaces have same width? I mean for example this line is misaligned.
Nic30
reviewed
May 14, 2026
| "engines" : { | ||
| "npm" : ">=8.5.1", | ||
| "node" : ">=12.22.9" | ||
| "engines": { |
Owner
There was a problem hiding this comment.
If possible avoid commiting style changes together with the code changes.
I hope you know about https://code.visualstudio.com/docs/sourcecontrol/staging-commits
Owner
|
Can you post the error message for layouter.terminateWorker()? try-catch ignore is definitely not a preferred solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i tried updating to elkjs only tests failed due to worker being terminated while during tests a fake worker was used. i wrapped the worker call in try/catch but i did dig deeper seems working in browser by using the examples and the tests passes