Issue #12 suggestion - add root and visibleOffset to useEffect deps#25
Open
pklingman wants to merge 1 commit intoNightCafeStudio:mainfrom
Open
Issue #12 suggestion - add root and visibleOffset to useEffect deps#25pklingman wants to merge 1 commit intoNightCafeStudio:mainfrom
pklingman wants to merge 1 commit intoNightCafeStudio:mainfrom
Conversation
|
Good fix. Btw, |
|
@pklingman I had to make same changes for my project for same reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #12
This is a great library! I think this PR would be helpful for one of our use cases for two main reasons, and also adding these props to the dependencies array follows the rule of hooks:
null- this allows root to be defined on subsequent renders. Using an element that is not available in the DOM on the first render is something we are currently doing.rootMarginin the intersection observer library is not applied