Skip to content
This repository was archived by the owner on Sep 26, 2018. It is now read-only.

Add backend conn stats JSON REST API and UI support#10

Merged
mihaitodor merged 5 commits intomasterfrom
backend-conn-stats
May 17, 2017
Merged

Add backend conn stats JSON REST API and UI support#10
mihaitodor merged 5 commits intomasterfrom
backend-conn-stats

Conversation

@mihaitodor
Copy link

@mihaitodor mihaitodor commented May 12, 2017

This adds the connection stats JSON REST API and the UI for visualising the data. Sample: https://media.giphy.com/media/xUPGcITQd0LHupfPYk/giphy.gif

@mihaitodor mihaitodor changed the title Backend conn stats Add backend conn stats JSON REST API and UI support May 12, 2017
@mihaitodor mihaitodor force-pushed the backend-conn-stats branch from 80ca48f to 97785b3 Compare May 12, 2017 13:46
web.go Outdated
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using these reflection hacks for now, but I'll talk with the project maintainers about customising their oxy fork to expose the totalConnections field (and maybe add more stats). Not sure what they're planning to do with that fork, considering that the maintainers of vulcand/oxy aren't very responsive.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just FYI, I noticed a while back their vendored oxy is different than the main oxy so I think they're already doing some customization.

Copy link
Author

@mihaitodor mihaitodor May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I can send them a PR for that lib too, but let's first see if they're interested in it and if they want any changes in the design. Before I send them the PR, I was hoping to get it running in our system to make sure everything is fine. There are loads of moving pieces...

@mihaitodor mihaitodor force-pushed the backend-conn-stats branch from 97785b3 to 2915907 Compare May 16, 2017 09:42
@mihaitodor
Copy link
Author

@relistan @bparli Please let me know if I can merge this one too.

@bparli
Copy link

bparli commented May 16, 2017

LGTM :shipit:

@mihaitodor mihaitodor merged commit 04aef51 into master May 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants