This repository was archived by the owner on Sep 26, 2018. It is now read-only.
Refactor deprecated Transport.CancelRequest method#12
Open
mihaitodor wants to merge 1 commit intomasterfrom
Open
Refactor deprecated Transport.CancelRequest method#12mihaitodor wants to merge 1 commit intomasterfrom
mihaitodor wants to merge 1 commit intomasterfrom
Conversation
mihaitodor
force-pushed
the
refactor-deprecated-method
branch
4 times, most recently
from
43bfb19 to
e8e5ae3
Compare
Author
|
We obviously need to use context here now, but I still don't see all the other changes as being necessary. |
Author
But I need to call the |
- Use context.WithCancel to cancel the watcher http request - Refactor code to allow closing the request body in a sane way - Declare variables in the in the narrowest possible scope
mihaitodor
force-pushed
the
refactor-deprecated-method
branch
from
e8e5ae3 to
8a26f01
Compare
mihaitodor
force-pushed
the
master
branch
2 times, most recently
from
e6c2040 to
7cfcede
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant discussions here and here.