hydra-eval-jobset: allow attributes other than checks/hydraJobs#1518
hydra-eval-jobset: allow attributes other than checks/hydraJobs#1518zowoq wants to merge 1 commit intoNixOS:masterfrom
Conversation
| "or flake.checks " . | ||
| "or (throw \"flake '$flakeRef' does not provide any Hydra jobs or checks\")"; | ||
| my $nix_expr; | ||
| my ($ref, $attr) = split '#', $flakeRef, 2; |
There was a problem hiding this comment.
Would be great to switch this over to --select: NixOS/nix-eval-jobs@5738c86
otherwise it's impure eval.
There was a problem hiding this comment.
of course we already had this issue before hand.
There was a problem hiding this comment.
Okay, for now I can cherry pick this and I can look at --select after this repo is updated to 2.31.
There was a problem hiding this comment.
I'll try to get the ci fixed for 2.31 asap.
There was a problem hiding this comment.
I don't mind carrying the patch for a while so don't rush the work on 2.31 unless you've got other reasons.
There was a problem hiding this comment.
We have the new nix-eval-jobs now.
| . ":\n" . ($stderr ? decode("utf-8", $stderr) : "(no output)\n") | ||
| if $res; | ||
| $flakeRef = decode_json($json)->{'url'}; | ||
| $ref = decode_json($json)->{'url'}; |
There was a problem hiding this comment.
With this PR the evaluator stops picking up new changes.
After testing I found out that this line should stay $flakeRef = decode_json($json)->{'url'};.
I'd like to be able to build different attrs from the same flake.