Skip to content

hydra-eval-jobset: allow attributes other than checks/hydraJobs#1518

Open
zowoq wants to merge 1 commit intoNixOS:masterfrom
qowoz:flake-attr
Open

hydra-eval-jobset: allow attributes other than checks/hydraJobs#1518
zowoq wants to merge 1 commit intoNixOS:masterfrom
qowoz:flake-attr

Conversation

@zowoq
Copy link
Copy Markdown
Contributor

@zowoq zowoq commented Aug 31, 2025

I'd like to be able to build different attrs from the same flake.

"or flake.checks " .
"or (throw \"flake '$flakeRef' does not provide any Hydra jobs or checks\")";
my $nix_expr;
my ($ref, $attr) = split '#', $flakeRef, 2;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to switch this over to --select: NixOS/nix-eval-jobs@5738c86

otherwise it's impure eval.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course we already had this issue before hand.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, for now I can cherry pick this and I can look at --select after this repo is updated to 2.31.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to get the ci fixed for 2.31 asap.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind carrying the patch for a while so don't rush the work on 2.31 unless you've got other reasons.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the new nix-eval-jobs now.

. ":\n" . ($stderr ? decode("utf-8", $stderr) : "(no output)\n")
if $res;
$flakeRef = decode_json($json)->{'url'};
$ref = decode_json($json)->{'url'};
Copy link
Copy Markdown

@mipmip mipmip Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR the evaluator stops picking up new changes.

After testing I found out that this line should stay $flakeRef = decode_json($json)->{'url'};.

@dasJ dasJ added the evaluator hydra-evaluator component label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

evaluator hydra-evaluator component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants