fix: Remove println that exposed secrets#1625
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Apr 8, 2026
Merged
Conversation
Member
|
Good catch! |
Member
|
One thing we could do is keep it on a really noisy debug level? In that case, if you debug that much, it is at your own peril? |
Member
|
we should merge this, as is. we dont really need this. I forgot to remove this, after implementing this, mybad |
Ericson2314
force-pushed
the
fix-remove-println
branch
from
5b117e4 to
78c1d79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two
printlns look like debugging output that was left over. The second one is harmless in the test, but the first one can leak AWS secrets in logs if I understand it correctly.