Merged
Conversation
It would be best to make these a single transaction, as they're linked Move them into a single statement
queue-runner: merge alloc_build_step and insert_build_step
The proto file already had `message StorePath { string path = 1; }`
but it was only used as a top-level RPC argument. Fields like
`BuildMessage.drv`, `LogChunk.drv`, and `FetchRequisitesRequest.path`
were plain `string` even though they always contain store paths.
This commit changes those fields to use the `StorePath` message type,
making the schema self-documenting and paving the way for type-safe
gRPC code on the Rust side.
On the Rust side, a `ProtoStorePath` newtype in the `shared` crate
wraps `harmonia_store_core::store_path::StorePath` and implements
`prost::Message` to match the proto wire format. prost-build's
`extern_path` maps the proto `StorePath` message to this newtype,
so generated code uses `ProtoStorePath` directly — eliminating the
manual `parse_store_path` calls that were scattered across the gRPC
handlers.
Use `StorePath` message type in proto for store-path fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR to keep
nix-nextin sync withmaster.