Validate store dir in gRPC version check#1638
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Apr 4, 2026
Merged
Conversation
Builders and the queue-runner must agree on the Nix store directory (typically `/nix/store`) or else store paths exchanged over the protocol wil be unactionable (store dirs are included in store path hash calcualtion). The version check handshake already runs before any builds are dispatched, so this is the natural place to catch the mismatch early with a clear error. Add a `store_dir` field to `VersionCheckRequest` in the proto, send it from the builder, and verify it on the queue-runner side — returning `failed_precondition` on mismatch. Also tighten up `nix_utils::get_store_dir()` to return `StoreDir` directly instead of `String`, to be more informative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builders and the queue-runner must agree on the Nix store directory (typically
/nix/store) or else store paths exchanged over the protocol wil be unactionable (store dirs are included in store path hash calcualtion).The version check handshake already runs before any builds are dispatched, so this is the natural place to catch the mismatch early with a clear error.
Add a
store_dirfield toVersionCheckRequestin the proto, send it from the builder, and verify it on the queue-runner side — returningfailed_preconditionon mismatch.Also tighten up
nix_utils::get_store_dir()to returnStoreDirdirectly instead ofString, to be more informative.