Replace queue-runner-build-one.sh with Perl module `QueueRunnerBuil…#1640
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Apr 4, 2026
Merged
Replace queue-runner-build-one.sh with Perl module `QueueRunnerBuil…#1640Ericson2314 merged 1 commit intoNixOS:masterfrom
queue-runner-build-one.sh with Perl module `QueueRunnerBuil…#1640Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
…dOne` It's generally better to use fewer languages. The bash script was the only non-Perl script in the test suite and was only invoked from `CliRunners::runBuilds`, meaning Perl was shelling out to bash just in one spot, for one purpose. A concrete benefit of the rewrite is we can reuse `getHydraConfig` instead of an ad-hoc `sed` script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dOne`
It's generally better to use fewer languages. The bash script was the only non-Perl script in the test suite and was only invoked from
CliRunners::runBuilds, meaning Perl was shelling out to bash just in one spot, for one purpose.A concrete benefit of the rewrite is we can reuse
getHydraConfiginstead of an ad-hocsedscript.