Skip to content

droopy: Fix Python 3.9 compatiblity#145702

Merged
Profpatsch merged 3 commits intoNixOS:masterfrom
georgefst:patch-1
Nov 21, 2021
Merged

droopy: Fix Python 3.9 compatiblity#145702
Profpatsch merged 3 commits intoNixOS:masterfrom
georgefst:patch-1

Conversation

@georgefst
Copy link
Copy Markdown
Contributor

Motivation for this change

Droopy has been broken since the update to Python 3.9. This change brings in the fairly trivial unmerged PR at stackp/Droopy#31, which adds compatibility.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Copy Markdown
Contributor

@tpwrules tpwrules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not evaluate as written. nixpkgs-review is a great tool to verify that your PRs build properly before submitting them. It would be a good idea to use that in the future.

url = "https://patch-diff.githubusercontent.com/raw/stackp/Droopy/pull/30.patch";
sha256 = "Y6jBraKvVQAiScbvLwezSKeWY3vaAbhaNXEGNaItigQ=";
})
(pkgs.fetchpatch {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should simply be fetchpatch.

@georgefst
Copy link
Copy Markdown
Contributor Author

This does not evaluate as written. nixpkgs-review is a great tool to verify that your PRs build properly before submitting them. It would be a good idea to use that in the future.

Thanks, I was in a rush and figured this was so simple I could get away with it. Guess I learnt my lesson!

Thanks for the suggestion of nixpkgs-review. I'll use that in future.

@jyooru
Copy link
Copy Markdown
Member

jyooru commented Nov 13, 2021

Result of nixpkgs-review pr 145702 run on x86_64-linux 1

1 package built:
  • droopy

@ofborg ofborg bot requested a review from Profpatsch November 13, 2021 12:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 13, 2021
@Profpatsch Profpatsch merged commit e156e78 into NixOS:master Nov 21, 2021
@Profpatsch
Copy link
Copy Markdown
Member

thanks!

@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants