Skip to content

nvidiaCtkPackages: fix misinterpreted ldflags#288588

Merged
SomeoneSerge merged 1 commit intoNixOS:masterfrom
SomeoneSerge:fix/nvidia-ctk-ldflags
Feb 13, 2024
Merged

nvidiaCtkPackages: fix misinterpreted ldflags#288588
SomeoneSerge merged 1 commit intoNixOS:masterfrom
SomeoneSerge:fix/nvidia-ctk-ldflags

Conversation

@SomeoneSerge
Copy link
Contributor

eeb1b2f has completely misinterpreted the flags

Description of changes

Hotfix for #278969 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

eeb1b2f has completely misinterpreted the flags
@SomeoneSerge
Copy link
Contributor Author

@ofborg build nvidia-docker nvidia-podman

@ofborg ofborg bot requested a review from cpcloud February 13, 2024 16:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 13, 2024
@SomeoneSerge
Copy link
Contributor Author

self-merging because otherwise nvidia-docker and apptainer are unusable on master; I did wait for ofborg

@SomeoneSerge SomeoneSerge merged commit 9f5d297 into NixOS:master Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant