Skip to content

corretto,adoptopenjdk: cleanup#314384

Closed
Infinidoge wants to merge 3 commits intoNixOS:masterfrom
Infinidoge:bump-openjdk-misc
Closed

corretto,adoptopenjdk: cleanup#314384
Infinidoge wants to merge 3 commits intoNixOS:masterfrom
Infinidoge:bump-openjdk-misc

Conversation

@Infinidoge
Copy link
Contributor

Description of changes

Split from #286267

CCing @thiagokokada @philiptaron as previous reviewers

Small cleanup bits from the original PR that didn't fit into the other split PRs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Infinidoge Infinidoge mentioned this pull request May 24, 2024
13 tasks
@Infinidoge
Copy link
Contributor Author

Folded into #314380

@Infinidoge Infinidoge closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants