lib/systems: set gcc.arch = "armv6kz", gcc.fpu = "vfpv2" for raspberryPi#327778
Merged
Conversation
Member
Author
|
Hm, found #205176 (comment). Probably still worth updating the named platform preset to avoid confusion. |
Contributor
|
|
Member
Author
>The CPU in the Raspberry Pi 1 and Zero implements the ARMv6 ISA (with VFP2) https://wiki.debian.org/RaspberryPi#:~:text=The%20CPU%20in%20the%20Raspberry%20Pi,VFP2%29 See also - https://en.wikipedia.org/wiki/Raspberry_Pi#Specifications - NixOS#319036 (comment)
Member
Author
|
@alyssais, gentle ping. Would you mind taking a look at this? |
Member
Author
Also cc @samueldr. We still have product-named platforms and I think it makes sense to have reasonable defaults, even if we intend to remove them in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See also
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.