Skip to content

nodejs_20: 20.15.1 -> 20.17.0#338188

Closed
fabianschmitthenner wants to merge 1 commit into
NixOS:masterfrom
fabianschmitthenner:update/nodejs-2.20
Closed

nodejs_20: 20.15.1 -> 20.17.0#338188
fabianschmitthenner wants to merge 1 commit into
NixOS:masterfrom
fabianschmitthenner:update/nodejs-2.20

Conversation

@fabianschmitthenner

Copy link
Copy Markdown

Description of changes

Update nodejs_20 to 20.17.0. We can remove 4 patches as they are included upstream in 20.17.0. We add another patch from nodejs (nodejs/node@02b3095) to fix test-cli-permission test.

Another two tests were failing for me (test-cluster-primary-kill,test-cluster-primary-error), which we maybe want to add to the list of ignored patches in nodejs.nix (or do we maybe want to only add them for v20.nix?). I haven't figured out why they are failing.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Aug 29, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Aug 29, 2024
@ofborg ofborg Bot requested a review from aduh95 August 29, 2024 14:39
@ofborg ofborg Bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Aug 29, 2024
@aduh95

aduh95 commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

Already addressed by #329655 and #336388, backport for 24.05 is #336570. Thanks though!

@aduh95 aduh95 closed this Aug 29, 2024
@fabianschmitthenner

Copy link
Copy Markdown
Author

Ah, I should have checked if this is already in staging branch as well 💡. Thanks for linking the PRs.

@fabianschmitthenner fabianschmitthenner deleted the update/nodejs-2.20 branch August 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants