Skip to content

treewide: use gitSetupHook#406679

Closed
drupol wants to merge 34 commits into
NixOS:masterfrom
drupol:push-lquqqmpxznos
Closed

treewide: use gitSetupHook#406679
drupol wants to merge 34 commits into
NixOS:masterfrom
drupol:push-lquqqmpxznos

Conversation

@drupol
Copy link
Copy Markdown
Contributor

@drupol drupol commented May 13, 2025

This PR

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol force-pushed the push-lquqqmpxznos branch from 4f60a6a to b5b7d16 Compare May 13, 2025 06:13
@github-actions github-actions Bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels May 13, 2025
@drupol drupol force-pushed the push-lquqqmpxznos branch from b5b7d16 to afd9d4f Compare May 13, 2025 07:53
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 17, 2025
ethancedwards8
ethancedwards8 approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM when rebased.

drupol added 24 commits May 19, 2025 21:26
@drupol
git-bug-migration: modernize, cleanup
24f87c9
@drupol
git-bug-migration: use gitSetupHook
592c111
@drupol
git-up: use gitSetupHook
4f34bb1
@drupol
committed: use gitSetupHook
2405684
@drupol
git-dive: use gitSetupHook
6dbee00
@drupol
vtsls: use gitSetupHook
5093312
@drupol
python312Packages.uv-dynamic-versioning: use gitSetupHook
ae7553c
@drupol
python312Packages.dunamai: use gitSetupHook
d5a1e0f
@drupol
python312Packages.nbdime: use gitSetupHook
6601441
@drupol
dune-release: use gitSetupHook
d98107d
@drupol
dune-release: remove with lib;
67a6469
@drupol
dune-release: do not reuse pname
c423b6f
@drupol
dune-release: use makeBinaryWrapper
4eb6bdd
@drupol
dune-release: use writableTmpDirAsHomeHook
031eeb2
@drupol
cargo-crev: use gitSetupHook
c983c28
@drupol
cargo-crev: use writableTmpDirAsHomeHook
1134c3d
@drupol
committed: use writableTmpDirAsHomeHook
7204edc
@drupol
committed: use finalAttrs pattern
886a9bb
@drupol
python312Packages.commitizen: use gitSetupHook
3362f1a
@drupol
python312Packages.commitizen: use writableTmpDirAsHomeHook
fb9c747
@drupol
python312Packages.commitizen: remove with lib;
45151e3
@drupol
python312Packages.commitizen: remove disabled attribute
c80aef4
@drupol
python312Packages.gto: use gitSetupHook and writableTmpDirAsHomeHook
c1cf76a
@drupol
python312Packages.gto: use writableTmpDirAsHomeHook
7657357
@drupol drupol force-pushed the push-lquqqmpxznos branch from afd9d4f to 01aa567 Compare May 19, 2025 19:27
@ofborg ofborg Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 19, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels May 19, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 9, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 25, 2025
@drupol drupol closed this Aug 24, 2025
@drupol drupol deleted the push-lquqqmpxznos branch August 24, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drupol @ethancedwards8 @wegank