Skip to content

devenv: 1.9.1 -> 1.10#449555

Merged
tfc merged 1 commit into
NixOS:masterfrom
domenkozar:devenv-1.10
Oct 10, 2025
Merged

devenv: 1.9.1 -> 1.10#449555
tfc merged 1 commit into
NixOS:masterfrom
domenkozar:devenv-1.10

Conversation

@domenkozar
Copy link
Copy Markdown
Member

@domenkozar domenkozar commented Oct 7, 2025

https://devenv.sh/blog/2025/10/07/devenv-110-monorepo-nix-support-with-devenvyaml-imports/

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 7, 2025
@nix-owners nix-owners Bot requested a review from sandydoo October 7, 2025 16:33
@sandydoo
Copy link
Copy Markdown
Contributor

sandydoo commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449555
Commit: 488c81284ce1b1c3a6dedae08496abcab3a4b97d


x86_64-linux

✅ 1 package built:
  • devenv

aarch64-linux

✅ 1 package built:
  • devenv

x86_64-darwin

✅ 1 package built:
  • devenv

aarch64-darwin

✅ 1 package built:
  • devenv

Comment thread pkgs/by-name/de/devenv/package.nix Outdated

buildAndTestSubdir = "devenv";

nativeBuildInputs = [
gitMinimal
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in nativeCheckInputs = [ gitMinimal ];

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right!

@sandydoo
Copy link
Copy Markdown
Contributor

sandydoo commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449555
Commit: e3413884e6fba3a6e0479604ed51822b31bf3cce


x86_64-linux

✅ 1 package built:
  • devenv

aarch64-linux

✅ 1 package built:
  • devenv

x86_64-darwin

✅ 1 package built:
  • devenv

aarch64-darwin

✅ 1 package built:
  • devenv

gitMinimal
];

preCheck = ''
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use gitSetupHook instead too ! #402320

Copy link
Copy Markdown
Contributor

@thenonameguy thenonameguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eagerly waiting for this to land 👍

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 9, 2025
@tfc tfc enabled auto-merge October 10, 2025 07:42
@tfc tfc added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:master with commit 06ded7c Oct 10, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants