Skip to content

scion-bootstrapper: 0.0.7 -> 0.0.8-unstable-2024-11-28; small improvements#457023

Merged
imincik merged 2 commits intoNixOS:masterfrom
eljamm:update/scion-bootstrapper
Oct 31, 2025
Merged

scion-bootstrapper: 0.0.7 -> 0.0.8-unstable-2024-11-28; small improvements#457023
imincik merged 2 commits intoNixOS:masterfrom
eljamm:update/scion-bootstrapper

Conversation

@eljamm
Copy link
Copy Markdown
Contributor

@eljamm eljamm commented Oct 30, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 30, 2025
@eljamm
Copy link
Copy Markdown
Contributor Author

eljamm commented Oct 30, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 457023
Commit: f1313d8c2020e0afcc034d272a476bfd0b9aa585 (subsequent changes)
Merge: fdfac25b2f5db9ca5d88c4aa1938ed430ff2ba70

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/18946408696

x86_64-linux

✅ 1 package built:
  • scion-bootstrapper

aarch64-linux

✅ 1 package built:
  • scion-bootstrapper

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • scion-bootstrapper

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • scion-bootstrapper

@eljamm eljamm requested a review from OPNA2608 October 30, 2025 16:10
@eljamm eljamm force-pushed the update/scion-bootstrapper branch from f1313d8 to 1031f9a Compare October 30, 2025 16:11
@sarcasticadmin
Copy link
Copy Markdown
Member

sarcasticadmin commented Oct 30, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457023
Commit: 1031f9a88513d7c0d62ed179af98f4e27a9d8ff9

x86_64-linux

✅ 1 package built:
  • scion-bootstrapper

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 30, 2025
@sarcasticadmin sarcasticadmin mentioned this pull request Oct 30, 2025
Open
@sarcasticadmin
Copy link
Copy Markdown
Member

sarcasticadmin commented Oct 30, 2025

@eljamm thanks for updating this to included the go 1.24+ patch. I also commented in the open PR: netsec-ethz/bootstrapper#31 (comment) hopefully this can be mainlined soon

@eljamm
Copy link
Copy Markdown
Contributor Author

eljamm commented Oct 30, 2025

Awesome, thanks.

@eljamm eljamm requested a review from imincik October 31, 2025 12:11
imincik
imincik approved these changes Oct 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you .

@imincik imincik added this pull request to the merge queue Oct 31, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 31, 2025
Merged via the queue into NixOS:master with commit 312a22c Oct 31, 2025
31 of 33 checks passed
@eljamm eljamm deleted the update/scion-bootstrapper branch October 31, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imincik imincik imincik approved these changes

@MatthewCroughan MatthewCroughan Awaiting requested review from MatthewCroughan

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

+1 more reviewer

@sarcasticadmin sarcasticadmin sarcasticadmin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eljamm @sarcasticadmin @imincik