Skip to content

stestrCheckHook: init#489221

Merged
SuperSandro2000 merged 3 commits into
NixOS:masterfrom
Vinetos:stestr-check-hook
Feb 23, 2026
Merged

stestrCheckHook: init#489221
SuperSandro2000 merged 3 commits into
NixOS:masterfrom
Vinetos:stestr-check-hook

Conversation

@Vinetos
Copy link
Copy Markdown
Member

@Vinetos Vinetos commented Feb 10, 2026 •
edited
Loading

This adds a useful hook to be used for projects that use stestr,
it is primiative at the moment but covers most scenarios for using
it.

This PR also changes a Python module to start using it, once it
lands, follow up PRs can update all of them to use it tree-wide.

This MR replaces #403456
This also resolves build failure on Python 3.14 for OpenStack packages : #475732

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@Vinetos
Copy link
Copy Markdown
Member Author

Vinetos commented Feb 10, 2026

Force pushed to sign my commits 😄

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation labels Feb 10, 2026
@Vinetos
Copy link
Copy Markdown
Member Author

Vinetos commented Feb 10, 2026 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 489221
Commit: a8642d6db0d616277c035dfbcfd52704e12eebe8

x86_64-linux

✅ 29 packages built:
  • heatclient (python313Packages.python-heatclient)
  • heatclient.dist (python313Packages.python-heatclient.dist)
  • magnumclient (python313Packages.python-magnumclient)
  • magnumclient.dist (python313Packages.python-magnumclient.dist)
  • neutronclient (python313Packages.python-neutronclient)
  • neutronclient.dist (python313Packages.python-neutronclient.dist)
  • nixpkgs-manual
  • openstackclient (python313Packages.python-openstackclient)
  • openstackclient-full
  • openstackclient-full.dist
  • openstackclient.dist (python313Packages.python-openstackclient.dist)
  • python313Packages.python-octaviaclient
  • python313Packages.python-octaviaclient.dist
  • troveclient (python313Packages.python-troveclient)
  • troveclient.dist (python313Packages.python-troveclient.dist)
  • python313Packages.stestrCheckHook
  • python314Packages.python-heatclient
  • python314Packages.python-heatclient.dist
  • python314Packages.python-magnumclient
  • python314Packages.python-magnumclient.dist
  • python314Packages.python-neutronclient
  • python314Packages.python-neutronclient.dist
  • python314Packages.python-octaviaclient
  • python314Packages.python-octaviaclient.dist
  • python314Packages.python-openstackclient
  • python314Packages.python-openstackclient.dist
  • python314Packages.python-troveclient
  • python314Packages.python-troveclient.dist
  • python314Packages.stestrCheckHook
./results/heatclient-x86_64-linux/bin/heat --version
5.0.0
./results/openstackclient-x86_64-linux/bin/openstack --version
openstack 8.3.0

ethancedwards8
ethancedwards8 suggested changes Feb 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ethancedwards8 ethancedwards8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may also need an entry in the release notes?

related: #402320

Comment thread pkgs/development/python-modules/python-heatclient/default.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes labels Feb 11, 2026
@Vinetos
Copy link
Copy Markdown
Member Author

Vinetos commented Feb 11, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 489221
Commit: 9c899a32c04ad00c28919524eb7a8305e23ad9b0

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 29 packages built:
  • heatclient (python313Packages.python-heatclient)
  • heatclient.dist (python313Packages.python-heatclient.dist)
  • magnumclient (python313Packages.python-magnumclient)
  • magnumclient.dist (python313Packages.python-magnumclient.dist)
  • neutronclient (python313Packages.python-neutronclient)
  • neutronclient.dist (python313Packages.python-neutronclient.dist)
  • nixpkgs-manual
  • openstackclient (python313Packages.python-openstackclient)
  • openstackclient-full
  • openstackclient-full.dist
  • openstackclient.dist (python313Packages.python-openstackclient.dist)
  • python313Packages.python-octaviaclient
  • python313Packages.python-octaviaclient.dist
  • troveclient (python313Packages.python-troveclient)
  • troveclient.dist (python313Packages.python-troveclient.dist)
  • python313Packages.stestrCheckHook
  • python314Packages.python-heatclient
  • python314Packages.python-heatclient.dist
  • python314Packages.python-magnumclient
  • python314Packages.python-magnumclient.dist
  • python314Packages.python-neutronclient
  • python314Packages.python-neutronclient.dist
  • python314Packages.python-octaviaclient
  • python314Packages.python-octaviaclient.dist
  • python314Packages.python-openstackclient
  • python314Packages.python-openstackclient.dist
  • python314Packages.python-troveclient
  • python314Packages.python-troveclient.dist
  • python314Packages.stestrCheckHook

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 11, 2026
anthonyroussel
anthonyroussel reviewed Feb 13, 2026
View reviewed changes
Comment thread pkgs/development/interpreters/python/hooks/stestr-check-hook.sh Outdated
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Feb 13, 2026
@Vinetos
Copy link
Copy Markdown
Member Author

Vinetos commented Feb 14, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 489221
Commit: 4eee3c9345c3a98599be09457935a02a586b662f

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 29 packages built:
  • heatclient (python313Packages.python-heatclient)
  • heatclient.dist (python313Packages.python-heatclient.dist)
  • magnumclient (python313Packages.python-magnumclient)
  • magnumclient.dist (python313Packages.python-magnumclient.dist)
  • neutronclient (python313Packages.python-neutronclient)
  • neutronclient.dist (python313Packages.python-neutronclient.dist)
  • nixpkgs-manual
  • openstackclient (python313Packages.python-openstackclient)
  • openstackclient-full
  • openstackclient-full.dist
  • openstackclient.dist (python313Packages.python-openstackclient.dist)
  • python313Packages.python-octaviaclient
  • python313Packages.python-octaviaclient.dist
  • troveclient (python313Packages.python-troveclient)
  • troveclient.dist (python313Packages.python-troveclient.dist)
  • python313Packages.stestrCheckHook
  • python314Packages.python-heatclient
  • python314Packages.python-heatclient.dist
  • python314Packages.python-magnumclient
  • python314Packages.python-magnumclient.dist
  • python314Packages.python-neutronclient
  • python314Packages.python-neutronclient.dist
  • python314Packages.python-octaviaclient
  • python314Packages.python-octaviaclient.dist
  • python314Packages.python-openstackclient
  • python314Packages.python-openstackclient.dist
  • python314Packages.python-troveclient
  • python314Packages.python-troveclient.dist
  • python314Packages.stestrCheckHook

@Vinetos Vinetos requested review from mweinelt and natsukium and removed request for mweinelt and natsukium February 17, 2026 19:36
@Vinetos
Copy link
Copy Markdown
Member Author

Vinetos commented Feb 17, 2026

My bad, I was trying Github Mobile.
This has not done what I expected.

SuperSandro2000
SuperSandro2000 reviewed Feb 19, 2026
View reviewed changes
Comment thread pkgs/development/interpreters/python/hooks/stestr-check-hook.sh Outdated
SuperSandro2000
SuperSandro2000 reviewed Feb 19, 2026
View reviewed changes
Comment thread pkgs/development/python-modules/python-heatclient/default.nix
@Vinetos Vinetos marked this pull request as draft February 20, 2026 20:40
@Vinetos
stestrCheckHook: init
38af642 
This adds a useful hook to be used for projects that use stestr,
it is primiative at the moment but covers most scenarios for using
it.

This PR also changes a Python module to start using it, once it
lands, follow up PRs can update all of them to use it tree-wide.

Signed-off-by: Vinetos <contact+git@vinetos.fr>
@Vinetos
python3Packages.python-openstackclient: use stestrCheckHook
0abace8 
Signed-off-by: Vinetos <contact+git@vinetos.fr>
@Vinetos
python3Packages.python-heatclient: use stestrCheckHook
3e0e730 
Signed-off-by: Vinetos <contact+git@vinetos.fr>
@Vinetos Vinetos marked this pull request as ready for review February 21, 2026 21:23
@Vinetos
Copy link
Copy Markdown
Member Author

Vinetos commented Feb 21, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: 3e0e730e1362a5f14b736c92166ae3809b95bc52

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 29 packages built:
  • heatclient (python313Packages.python-heatclient)
  • heatclient.dist (python313Packages.python-heatclient.dist)
  • magnumclient (python313Packages.python-magnumclient)
  • magnumclient.dist (python313Packages.python-magnumclient.dist)
  • neutronclient (python313Packages.python-neutronclient)
  • neutronclient.dist (python313Packages.python-neutronclient.dist)
  • nixpkgs-manual
  • openstackclient (python313Packages.python-openstackclient)
  • openstackclient-full
  • openstackclient-full.dist
  • openstackclient.dist (python313Packages.python-openstackclient.dist)
  • python313Packages.python-octaviaclient
  • python313Packages.python-octaviaclient.dist
  • troveclient (python313Packages.python-troveclient)
  • troveclient.dist (python313Packages.python-troveclient.dist)
  • python313Packages.stestrCheckHook
  • python314Packages.python-heatclient
  • python314Packages.python-heatclient.dist
  • python314Packages.python-magnumclient
  • python314Packages.python-magnumclient.dist
  • python314Packages.python-neutronclient
  • python314Packages.python-neutronclient.dist
  • python314Packages.python-octaviaclient
  • python314Packages.python-octaviaclient.dist
  • python314Packages.python-openstackclient
  • python314Packages.python-openstackclient.dist
  • python314Packages.python-troveclient
  • python314Packages.python-troveclient.dist
  • python314Packages.stestrCheckHook

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Feb 23, 2026
Merged via the queue into NixOS:master with commit 5b90dbc Feb 23, 2026
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonyroussel anthonyroussel anthonyroussel approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@natsukium natsukium Awaiting requested review from natsukium

+1 more reviewer

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Vinetos @anthonyroussel @SuperSandro2000 @ethancedwards8