You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @zeidlos, thanks for your contribution and taking the time to test it. I noticed you added qtmultimedia, thanks for picking that up. And sorry that I didn't pick up the new release earlier.
Review comments:
References seem fine, upstream changes seem fine as well, tested with my AT-UV878II as well, works fine.
No need to be sorry! Maintaining this is not a full time commitment and if I could help out, why not? Glad I didn't make any mistakes along the way. Thank you for your time and work on this!
I figured out the issue with the Darwin build.
qdmr 0.15.0 introduced a dependency on kdePackages.qtmultimedia which has some issues still pending #490318 and #492649 for Darwin.
What would be the best course of action?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Confirmed working with my UV-168 Pro. I could read/write a codeplug, and updating the callsign list worked as well.