Skip to content

fix: Mark HasProvider as synced if it has ever synced this session #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtkav wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Mark HasProvider as synced if it has ever synced this session #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/HasProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ export class HasProvider extends HasLogging {
path?: string;
ydoc: Y.Doc;
clientToken: ClientToken;
// Track if provider has ever synced. We use our own flag because
// _provider.synced can be reset to false on reconnection.
_providerSynced: boolean = false;
private _offConnectionError: () => void;
private _offState: () => void;
listeners: Map<unknown, Listener>;
Expand Down Expand Up @@ -216,7 +219,7 @@ export class HasProvider extends HasLogging {
}

public get synced(): boolean {
return this._provider.synced;
return this._providerSynced;
}

disconnect() {
Expand Down Expand Up @@ -249,11 +252,12 @@ export class HasProvider extends HasLogging {
}

onceProviderSynced(): Promise<void> {
if (this._provider.synced) {
if (this._providerSynced) {
return Promise.resolve();
}
return new Promise((resolve) => {
this._provider.once("synced", () => {
this._providerSynced = true;
resolve();
});
});
Expand Down