Fix flaky stderr race condition in ExternalParserTest nightly integration test#1280
Draft
Copilot wants to merge 2 commits into
Draft
Fix flaky stderr race condition in ExternalParserTest nightly integration test#1280Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Integration Test Suite (Nightly)
Fix flaky stderr race condition in ExternalParserTest nightly integration test
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExternalParserTest.testInFileOutFilewas intermittently failing withexpected: <StdErrAfter> but was: <null>becauseSystemCommandreads stdout and stderr on separate threads, andexecute()can return before the stderr listener thread has finished draining its final line.Root cause
assertMetadataalready had a retry loop forfield2(stdout_after) to tolerate this race, butfield4(stderr_after) had no such guard. Even after the stdout retry loop resolvesfield2, the stderr thread may still be processingStdErrAfter:field4.Fix
Added an equivalent retry loop for
field4inassertMetadata: