Redstone interface fixes (1.21.1)#132
Open
rafern wants to merge 6 commits into
Open
Conversation
BundledRedstone.isAvailable should probably also be deprecated, since you have to check that the return value of getBundledInput isn't null anyway. Either that, or BundledCableHandler.getBundledInput should never return null
Not super happy with the implementation, lots of copy-pasta. Code could be shared
|
I think this does clash with my PR as you point out, and that the issue is deep enough that the smaller fixes you do arenʼt really enough. Part of the problem is that you can pass either If GitHub had the concept of stacked PRs Iʼd suggest you rebase on top of mine, but it doesnʼt, so Iʼm not sure what the best option is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for bundled cables to the redstone interface card (interface block already supported it, but not the card that you put in the computer block, which was inconsistent), and fixed bugs related to the redstone interface card and block.
Bug fixes:
Note that, to test this, I had to change the NeoForge version to 21.1.222, and had to use this fork of MarkdownManual. These changes are not included.
Edit: there were some issues with handling of bundled cable directions, which are now fixed. I don't think I've fully understood how these are supposed to work though, as there seems to be some inconsistency between how directions are handled for redstone versus bundles, so more work might be needed